mca/parking_solution
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 10 Wiki Activity

feat(subs): admin can correct a subscription's plan VERSION

Browse Source 
A subscription froze its planVersionId at sale (reproducible pricing). There was
no way to move a sold sub onto a different VERSION of the SAME plan — needed when
an admin publishes v2 with different timeframes (e.g. mujor-naten-cdo-dite v1
"every day" → v2 "weekdays only") and wants an existing subscriber on it, or back
on v1.

Backend (PUT /api/subscriptions/:id):
- accept planVersionId; honored only with the subscription:plan permission
  (stronger than subscription:update — a plan-management action). Non-privileged
  caller sending a change → 403, not silently dropped.
- validated to belong to the sub's EXISTING planId (a different plan = a
  different price basis = a re-sale → 400).
- price/currency/period/planId stay frozen; only planVersionId moves. The swap is
  server-logged for audit (the row is mutable master data, not on the ledger).
  Past signed entry/exit events keep their own windowTariffVersionId, so history
  reprices identically — only future access uses the new version's windows.

Frontend (SubscriptionManager):
- pass the session user through the route (like RolesManager).
- admin-only "Versioni" picker in the edit modal: lists every version of the
  sub's plan by effective date + a timeframe summary (days + window, or 24/7),
  current pre-selected. The plan itself stays read-only. Sends planVersionId only
  when it changed.
- i18n: subs.version/versionHint/versionCurrent/versionOnlyOne/everyDay/allDay
  in both sq + en.

Verified on a writable DB copy: version changed, price + planId frozen,
cross-plan version rejected. Live DB untouched. build+lint 14/14.

Claude-Session: https://claude.ai/code/session_01Xcm6ikLgGoCxxHrxtjkk5V
This commit is contained in:
Julian Çuni
2026-06-21 14:08:58 +02:00
parent 31f116a068
commit 78d1f6808a
8 changed files with 183 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
wiki/entities/subscription.md
+12
View File
@@ -57,6 +57,18 @@ mutates an old one — past sales keep their recorded `planVersionId` and repric
sale, plus `planId` + `planVersionId` (which version priced it — reproducible, like a payment's
`tariffVersionId`). An **update never re-sells** (price/plan frozen); a new price = a new sale.
> **Version correction (admin, built 2026-06-21).** The one update that may move `planVersionId`:
> an admin can re-point a sub to a **different VERSION of its SAME plan** — e.g. v2 changed the
> timeframes (`days [0–6]` → weekdays-only) and an existing subscriber should be on it, or back on v1.
> `PUT /api/subscriptions/:id` accepts `planVersionId`, **gated on `subscription:plan`** (plan-mgmt,
> stronger than `subscription:update`; a non-privileged caller is 403'd, not silently ignored). It is
> validated to belong to the sub's existing `planId` (a different plan = a different price basis = a
> re-sale, refused with 400). **Price/currency/period stay frozen** — only the access rules change,
> and only going forward (past signed `vehicle_entry`/`exit` events keep their own frozen
> `windowTariffVersionId`, so history reprices identically). The swap is server-logged for audit (the
> `subscriptions` row is mutable master data, not on the signed ledger). UI: an admin-only "Version"
> picker in the edit modal, listing every version of that plan by effective date + timeframe summary.
> **Superseded — per-row typed price (built 2026-06-18).** Originally each subscription stored its own
> `priceMinor` + `period:"monthly"`, typed by the operator and pre-filled from
> `site_config.subscription_monthly_price_minor`. That column is **kept only to seed a "Monthly" plan**